Contract cleanup #809
Merged
Contract cleanup #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
commented
Aug 8, 2024
| @@ -612,7 +603,7 @@ impl VersionedMpcContract { | |||
|
|
|||
| // This function can be used to transfer the MPC network to a new contract. | |||
| #[private] | |||
| #[init(ignore_state)] | |||
There was a problem hiding this comment.
This function is less important since we plan to stick to 1 contract.
If we decide to move to another one - it should not have any state.
volovyks
commented
Aug 8, 2024
| @@ -798,22 +790,6 @@ impl VersionedMpcContract { | |||
| } | |||
| } | |||
|
|
|||
| #[private] | |||
| #[init(ignore_state)] | |||
| pub fn clean(keys: Vec<near_sdk::json_types::Base64VecU8>) -> Self { | |||
There was a problem hiding this comment.
Not needed since we will not have any FAKs.
volovyks
commented
Aug 8, 2024
| @@ -28,7 +28,6 @@ pub struct RunningContractState { | |||
| pub struct ResharingContractState { | |||
| pub old_epoch: u64, | |||
| pub old_participants: Participants, | |||
| // TODO: only store diff to save on storage | |||
There was a problem hiding this comment.
I do not think we should ever do this. The logic is not executed often and I prefer a simpler design.
ChaoticTempest
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.